From e9c7ec2a8cc3bb7213140cd8ccfc9c47179e6eb2 Mon Sep 17 00:00:00 2001 From: "Dr. David Alan Gilbert" Date: Thu, 25 Jun 2015 16:34:25 +0200 Subject: [PATCH 43/44] Migration compat for pckbd Message-id: <1435250065-17863-2-git-send-email-dgilbert@redhat.com> Patchwork-id: 66497 O-Subject: [RHEL-7.2 qemu-kvm-rhev PATCH 1/1] Migration compat for pckbd Bugzilla: 1215092 RH-Acked-by: Juan Quintela RH-Acked-by: Laszlo Ersek RH-Acked-by: Paolo Bonzini From: "Dr. David Alan Gilbert" 2.2 added a new subsection to the pc keyboard model to preserve the value of 'outport' across migration; to maintain migration backwards compatibility this patch disables it on older machine types. This leaves us no-worse-off than in older versions. Even with the new code, the value migrated in 'outport' isn't used anywhere in the pckbd model; for example the value migrated doesn't change the state of the A20 line or potentially do a reset. The only effect, as far as I can tell is if the guest were to explicitly read the outport value it might get a more sensible reply. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Miroslav Rezanina --- hw/input/pckbd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 9b9a7d7..d688836 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -25,6 +25,7 @@ #include "hw/isa/isa.h" #include "hw/i386/pc.h" #include "hw/input/ps2.h" +#include "migration/migration.h" #include "sysemu/sysemu.h" /* debug PC keyboard */ @@ -405,6 +406,11 @@ static const VMStateDescription vmstate_kbd_outport = { static bool kbd_outport_needed(void *opaque) { KBDState *s = opaque; + + if (migrate_pre_2_2) { + return false; + } + return s->outport != kbd_outport_default(s); } -- 1.8.3.1