From d6dfc823d55851e7f9b6a735ceb849db34431140 Mon Sep 17 00:00:00 2001 From: Max Reitz Date: Mon, 24 Nov 2014 09:09:44 +0100 Subject: [PATCH 6/6] qemu-img: fix rebase src_cache option documentation Message-id: <1416820184-3129-6-git-send-email-mreitz@redhat.com> Patchwork-id: 62549 O-Subject: [RHEV-7.1 qemu-kvm-rhev PATCH 5/5] qemu-img: fix rebase src_cache option documentation Bugzilla: 1166481 RH-Acked-by: Markus Armbruster RH-Acked-by: Kevin Wolf RH-Acked-by: Stefan Hajnoczi From: Stefan Hajnoczi The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags, old_backing_drv, &local_err); if (ret) { ... } if (out_baseimg[0]) { bs_new_backing = bdrv_new("new_backing", &error_abort); ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags, new_backing_drv, &local_err); if (ret) { ... } } The documentation only mentions the new backing file but it really applies to both. Suggested-by: Jeff Nelson Signed-off-by: Stefan Hajnoczi Reviewed-by: Max Reitz (cherry picked from commit 3ba6796d080a90440573ef29d657e4902be7e238) Signed-off-by: Max Reitz Signed-off-by: Miroslav Rezanina --- qemu-img.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.texi b/qemu-img.texi index 4380d56..cc4668e 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -341,7 +341,7 @@ string), then the image is rebased onto no backing file (i.e. it will exist independently of any backing file). @var{cache} specifies the cache mode to be used for @var{filename}, whereas -@var{src_cache} specifies the cache mode for reading the new backing file. +@var{src_cache} specifies the cache mode for reading backing files. There are two different modes in which @code{rebase} can operate: @table @option -- 1.8.3.1